Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zebra-network test where all address book peers are outdated #3048

Closed
Tracked by #2311
jvff opened this issue Nov 10, 2021 · 1 comment
Closed
Tracked by #2311

Add zebra-network test where all address book peers are outdated #3048

jvff opened this issue Nov 10, 2021 · 1 comment
Labels
A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network I-usability Zebra is hard to understand or use

Comments

@jvff
Copy link
Contributor

jvff commented Nov 10, 2021 •
edited by teor2345
Loading

Motivation

#3030 implemented a filter for outdated peers, so Zebra stops attempting to connect to peers that are likely unreachable. That PR added some unit tests, but it would be useful to have a separate integration test for it.

The integration test should check the following scenarios:

  • What does Zebra do if all its peers are outdated?
    • Zebra should keep crawling for new peers
  • What does it do if all its peers are outdated, and it has no open peer connections?
    • Zebra should wait for an inbound connection, crawl for new peers, then start connecting to peers again

Scheduling

This isn't required for the stable release, but it is probably something we should do for lightwalletd.

We should do this test earlier if the issue actually happens on Zebra nodes.
@jvff jvff added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Nov 10, 2021
@jvff jvff mentioned this issue Nov 10, 2021
Merged
3 tasks
@teor2345 teor2345 changed the title Add integration test for avoiding to reconnect to probably unreachable peers Add zebra-network test where all address book peers are outdated Nov 10, 2021
@teor2345 teor2345 added A-network Area: Network protocol updates or fixes I-usability Zebra is hard to understand or use P-Low labels Nov 10, 2021
@teor2345 teor2345 added C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network labels Dec 21, 2021
@ftm1000
Copy link

ftm1000 commented Jan 26, 2022

redistributing issues that can be separately worked from Epic #2311

@mpguerra mpguerra mentioned this issue Jan 27, 2022
Closed
40 tasks
@jvff jvff closed this as completed Mar 18, 2022
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-security Category: Security issues I-remote-node-overload Zebra can overload other nodes on the network I-usability Zebra is hard to understand or use
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mpguerra @jvff @teor2345 @ftm1000