Tracking: Security Issues

[mpguerra]

This epic issue tracks security fixes we might want to make at some point, as part of some of our high level goals (e.g #3096, #3134, #2814, etc... )

Issues

Stable Release

• Epic: Zebra Release Candidate #3096
  • Always shut down the tokio runtime before exiting zebra #3384
  • Stop ignoring dependency changes in the Cargo.lock up-to-date check  #3388
  • forbid(non_ascii_idents) in all the Zebra crates #1143
  • Review the Ziggurat Report and check if there are any missing network fixes #3278
  • Support the large block heights required by the spec #1113
  • Add outbound peer message timeout #3234
  • Security: Send notfound inv items to the inv collector, Credit: Equilibrium #2156
  • ZG-CONFORMANCE-003-006: ignore non-Version/Verack messages during the handshake #3429

Lightwalletd

• Epic: Zebra as a lightwalletd backend #3134
  • Use the AtLeastOne generic type to enforce field counts #2028
  • Fully anonymise timestamps in version messages when broadcasting transactions #3300
  • Security: Prevent inv and AddressBook message denial of service #3271
  • Add zebra-network test where all address book peers are outdated #3048
  • Stop using private IP addresses by default #3117
  • Stop parsing a block height from the genesis block coinbase data #3118
  • Reduce the number of Zebra dependencies, and remove duplicate dependencies #3184
  • Fan out PushTransaction requests to multiple peers #3242
  • Zebra should store a persistent list of recent successful peers #1956
  • Limit fanouts to the number of active peers, Credit: Equilibrium #2214
  • Clearly identify 32-bit and 64-bit times in serialization and proptests #2171
  • Security: Remove the ErrorSlot from the heartbeat and connection tasks #3263
  • Use DateTime32 for block times and lock times #2211
  • Run Ziggurat tests as part of Zebra's CI #2434

NU6

• Epic: NU6 Activation #2814
  • Add hashAuthDataRoot to Block network messages, and semantically verify it #2336
  • Make old Zebra versions eventually refuse to run #1870

Documentation

• Document how we review network protocol changes after audits #3187
• Document how we review consensus rule changes after audits #3186
• Document how we review mempool behaviour changes after audit #3188
• Document how we review dependency changes #3183

Troubleshooting

• Integrate tokio-console #2112
• Create a DNS seeder health check utility #2137

Other

• Ignore and sanitize untrusted MetaAddr peer services #2324
• Use cap-std to secure filesystem and network access #2340
• Create a CanonicalAddr serialization and key type #2364
• Test if checkpoint verifier and state service are correctly reset on block commit errors #2654 - (to be done anytime post NU5 mainnet activation)
• Avoid deadlocks in the crawler by doing address book updates and handshakes in separate tasks #3288
• Move the coinbase decryption check to the transaction verifier #3290
• Stop logging IP addresses and mempool transaction IDs by default, to protect user privacy #3320
• Security: rate-limit outbound messages, Credit: Equilibrium #2153
• Zebra attempts new peer connections in a fixed, predictable order #1875
• Verify headers first, to avoid large block denial of service #1166

[mpguerra]

Changing this from an Epic to a tracking issue

[teor2345]

We're tracking these tasks using the Security GitHub tag.