Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZG-CONFORMANCE-003-006: ignore non-Version/Verack messages during the handshake #3429

Closed
Tracked by #3413 ...
teor2345 opened this issue Jan 27, 2022 · 1 comment · Fixed by #3522
Closed
Tracked by #3413 ...

ZG-CONFORMANCE-003-006: ignore non-Version/Verack messages during the handshake #3429

teor2345 opened this issue Jan 27, 2022 · 1 comment · Fixed by #3522
Assignees
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jan 27, 2022

Motivation

The Ziggurat team picked up some handshake bugs we should fix:
https://github.com/eqlabs/ziggurat#conformance
https://github.com/eqlabs/ziggurat/blob/master/SPEC.md#zg-conformance-003

Tasks

In the handshake:

  • ignore unexpected messages while waiting for Version
  • ignore unexpected messages while waiting for Verack
@teor2345 teor2345 changed the title ZG-CONFORMANCE-003-006: ignore non-Version/Verack messages before and during the handshake ZG-CONFORMANCE-003-006: ignore non-Version/Verack messages during the handshake Jan 28, 2022
@teor2345 teor2345 added A-network Area: Network protocol updates or fixes C-bug Category: This is a bug P-Medium ⚡ labels Jan 28, 2022
@teor2345 teor2345 mentioned this issue Jan 28, 2022
40 tasks
@mpguerra mpguerra added the S-needs-triage Status: A bug report needs triage label Jan 28, 2022
@ftm1000
Copy link

ftm1000 commented Feb 9, 2022

@oxarbitrage oxarbitrage self-assigned this Feb 10, 2022
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Feb 14, 2022
@mergify mergify bot closed this as completed in #3522 Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants