Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always shut down the tokio runtime before exiting zebra #3384

Closed
Tracked by #2311
teor2345 opened this issue Jan 23, 2022 · 1 comment
Closed
Tracked by #2311

Always shut down the tokio runtime before exiting zebra #3384

teor2345 opened this issue Jan 23, 2022 · 1 comment
Labels
A-rust Area: Updates to Rust code C-security Category: Security issues I-crash Zebra crashes (without a panic)

Comments

@teor2345
Copy link
Contributor

Scheduling

If #3133 removes all the calls to app_writer().shutdown(), then we don't need to do this task until the lightwalletd work.

Motivation

After we fix #3133, we might need to shut down the tokio run time before the Zebra abscissa application shuts down. This avoids a potential security issue where the tokio runtime threads are forced to shut down without cleaning up properly.

APIs

https://docs.rs/abscissa_core/0.5.2/abscissa_core/component/trait.Component.html#method.before_shutdown

https://docs.rs/abscissa_core/0.5.2/abscissa_core/application/trait.Application.html#method.shutdown

@teor2345 teor2345 added A-rust Area: Updates to Rust code S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-security Category: Security issues I-crash Zebra crashes (without a panic) labels Jan 23, 2022
@teor2345
Copy link
Contributor Author

This seems to be covered by PR #3133. If we find this kind of bug in other code that shuts down Zebra, we should open a specific ticket for it.

@mpguerra mpguerra mentioned this issue Jan 27, 2022
40 tasks
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-security Category: Security issues I-crash Zebra crashes (without a panic)
Projects
None yet
Development

No branches or pull requests

2 participants