Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a new v5 transaction script verification API to zcash_script and Zebra #3291

Closed
teor2345 opened this issue Dec 24, 2021 · 2 comments
Closed

Add a new v5 transaction script verification API to zcash_script and Zebra #3291

teor2345 opened this issue Dec 24, 2021 · 2 comments
Assignees
@conradoplg
Labels
A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Dec 24, 2021 •
edited by conradoplg
Loading

Motivation

We want to modify ZIP-244 to include all UTXO values and scripts in each input's sighash.

This requires updates to zcashd's script module, zcash_script, zebra-script, and zebra-consensus.

Specifications

ZIP 244 - Changes to transparent component of signature digest

TODO: quote consensus rules after the ZIP PR merges

Designs

Zebra changes:

  • Propose a API update to zcashd's script module with a v5 script verification precompute function, which takes the the concatenated serialized bytes of all the spent outputs for a transaction
  • Update zebra-consensus to wait for all the UTXOs, then pass them to where the new zebra-script v5 function will be called
@teor2345 teor2345 added A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage NU-5 Network Upgrade: NU5 specific tasks P-Medium labels Dec 24, 2021
@teor2345 teor2345 changed the title Update Zebra to use the new v5 transaction script verification API Add a new v5 transaction script verification API to zcash_script and Zebra Jan 4, 2022
@teor2345 teor2345 mentioned this issue Jan 4, 2022
Closed
50 tasks
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @jvff @oxarbitrage @teor2345 @upbqdn

@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Jan 18, 2022
@conradoplg conradoplg mentioned this issue Jan 26, 2022
Merged
3 tasks
@mpguerra mpguerra added the S-blocked Status: Blocked on other tasks label Jan 27, 2022
@conradoplg conradoplg mentioned this issue Feb 11, 2022
Closed
5 tasks
@conradoplg conradoplg removed the S-blocked Status: Blocked on other tasks label Feb 11, 2022
@conradoplg
Copy link
Collaborator

Split the remaining part into #3520.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conradoplg conradoplg

Labels
A-consensus Area: Consensus rule updates C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@conradoplg @mpguerra @teor2345 @ftm1000