Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new v5 transaction script verification API #3520

Closed
4 of 5 tasks
conradoplg opened this issue Feb 11, 2022 · 1 comment · Fixed by #3799
Closed
4 of 5 tasks

Use new v5 transaction script verification API #3520

conradoplg opened this issue Feb 11, 2022 · 1 comment · Fixed by #3799
Assignees
@conradoplg
Labels
C-enhancement Category: This is an improvement S-blocked Status: Blocked on other tasks

Comments

@conradoplg
Copy link
Collaborator

conradoplg commented Feb 11, 2022 •
edited
Loading

Motivation

Split off from #3291

ZIP-244 changes will require a change in the script verification API. In #3291 we prepared for that change by changing our internal APIs and having the additional information needed for verification ready.

Specifications

Designs

  • Update to a zcash_script version with the new API
  • Update zebra-script with a safe interface to the new v5 function
  • API consistency: also add a non-precomputed function to zcash_script and zebra-script
  • Call it where needed
  • Update ZIP-244 test vectors

Related Work
@conradoplg conradoplg added S-blocked Status: Blocked on other tasks C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Feb 11, 2022
@conradoplg conradoplg mentioned this issue Feb 11, 2022
Closed
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Feb 14, 2022
@teor2345 teor2345 assigned conradoplg and unassigned teor2345 Feb 24, 2022
@conradoplg conradoplg mentioned this issue Mar 8, 2022
Merged
3 tasks
@conradoplg
Copy link
Collaborator Author

  • API consistency: also add a non-precomputed function to zcash_script and zebra-script

I didn't do this in zebra-script since we only seem to use the precomputed API

@conradoplg conradoplg mentioned this issue Mar 10, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@conradoplg conradoplg

Labels
C-enhancement Category: This is an improvement S-blocked Status: Blocked on other tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(nu5): use new V5 transaction script verification API ZcashFoundation/zebra
3 participants
@conradoplg @teor2345 @ftm1000