Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create testing instances before deploying to main #3362

Closed
gustavovalverde opened this issue Jan 17, 2022 · 3 comments
Closed

Create testing instances before deploying to main #3362

gustavovalverde opened this issue Jan 17, 2022 · 3 comments
Assignees
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-enhancement Category: This is an improvement

Comments

@gustavovalverde
Copy link
Member

Motivation

  • Some issues might arise just after a successful deployment to the infrastructure (GCP so far)
  • Local testing environment and the production environment might differ
  • We might want to evaluate the "actual" time a PR might take to sync on the blockchain up to the tip or any similar behavior

Designs

  • When a PR passes the CI, deploy a testing instance and report back to GitHub with a health-check to confirm it was successfully deployed and everything is working as expected.
  • If this Integration Test fails, we must validate before reviewing/merging to the main branch
@gustavovalverde gustavovalverde added A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Jan 17, 2022
@gustavovalverde gustavovalverde self-assigned this Jan 17, 2022
@conradoplg
Copy link
Collaborator

  • If this Integration Test fails, we must validate before reviewing/merging to the main branch

One issue is that sync takes hours, so it could make things difficult when merging a bunch of PRs one after another.
Not sure if we should just accept it, or maybe allowing merging to main (as long as the other tests pass) but running the sync test and notifying if it breaks, so that we can prioritize fixing it.

@conradoplg
Copy link
Collaborator

@gustavovalverde @teor2345 Just to check, this is blocked on us trying to make sync faster and deciding to enforce this on PRs, or to just to test it asynchronously, right?

@teor2345
Copy link
Contributor

I think this extra testing is a good idea, but there are other things that are a higher priority, like:

@ZcashFoundation ZcashFoundation locked and limited conversation to collaborators Feb 28, 2022
@gustavovalverde gustavovalverde converted this issue into discussion #3670 Feb 28, 2022

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-infrastructure Area: Infrastructure changes C-enhancement Category: This is an improvement
Projects
None yet
Development

No branches or pull requests

5 participants