-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: temporarily allow forked repos to run PR workflows #3503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting this done so quickly!
(And thanks for linking the follow-up ticket in the PR, it's good to know what the next steps are.)
Codecov Report
@@ Coverage Diff @@
## main #3503 +/- ##
==========================================
+ Coverage 78.34% 78.49% +0.15%
==========================================
Files 267 273 +6
Lines 31526 31900 +374
==========================================
+ Hits 24698 25041 +343
- Misses 6828 6859 +31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not update a direct dependency of our Docker image to be writeable by a PR from anywhere, a local branch or a fork branch, before that change has been approved by a human and merged to #main :
Line 58 in a872f17
COPY --from=us-docker.pkg.dev/zealous-zebra/zebra/zcash-params /root/.zcash-params /root/.zcash-params |
We should not update a direct dependency of our Docker image to be writeable by a PR from anywhere, a local branch or a fork branch, before that change has been approved by a human and merged to #main : Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
Motivation
The continuous deployment refactors included a workflow to cache Zcash parameters, which was triggered by a
pull_request
event. But when triggered from a forked repo, this event does not have the right context nor permissions to read secretsSpecifications
https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target
Solution
Temporarily use
pull_request_target
instead ofpull_request
Review
@teor2345
Follow Up Work
This is a temporal fix, which needs to be solved with #3419