Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: block validation #428

Closed
4 of 7 tasks
teor2345 opened this issue Jun 4, 2020 · 8 comments
Closed
4 of 7 tasks

Tracking: block validation #428

teor2345 opened this issue Jun 4, 2020 · 8 comments
Labels
A-consensus Area: Consensus rule updates C-tracking-issue Category: This is a tracking issue for other tasks Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jun 4, 2020

Create a block validation service, which validates blocks and transactions. This service should perform semantic validation, before submitting blocks to the state for contextual validation.

Used by the block fetching and validation service in #140.

@teor2345 teor2345 added Poll::Ready C-research Category: Engineering notes in support of design choices A-consensus Area: Consensus rule updates labels Jun 4, 2020
@teor2345 teor2345 self-assigned this Jun 4, 2020
@hdevalence

This comment has been minimized.

@teor2345

This comment has been minimized.

@teor2345

This comment has been minimized.

@daira

This comment has been minimized.

@teor2345

This comment has been minimized.

@hdevalence

This comment has been minimized.

@teor2345 teor2345 mentioned this issue Jun 8, 2020
2 tasks
@teor2345

This comment has been minimized.

teor2345 added a commit to teor2345/zebra that referenced this issue Jun 11, 2020
Add validation for:
  - blocks in the chain, and
  - transactions in the chain and mempool.

Also:
  - Note that zebra-script may do some script validation.
  - Describe the zebra-consensus dependencies.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 11, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 11, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 11, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 11, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 11, 2020
We want to allow different state service implementations, and wrapped
state services. So we make verify::init() take a state_service, and
store that service in the BlockVerifier state_service field.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 11, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 11, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 12, 2020
This test doesn't work, because the futures are not used correctly.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 12, 2020
Move block header hashing from zebra-consensus to zebra-state.
Handle zebra-state AddBlock errors in zebra-consensus BlockVerifier.
Add unit tests for BlockVerifier state error handling.

Part of ZcashFoundation#428.
hdevalence pushed a commit that referenced this issue Jun 12, 2020
Add validation for:
  - blocks in the chain, and
  - transactions in the chain and mempool.

Also:
  - Note that zebra-script may do some script validation.
  - Describe the zebra-consensus dependencies.

Part of #428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
We want to allow different state service implementations, and wrapped
state services. So we make verify::init() take a state_service, and
store that service in the BlockVerifier state_service field.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
This test doesn't work, because the futures are not used correctly.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
Move block header hashing from zebra-consensus to zebra-state.
Handle zebra-state AddBlock errors in zebra-consensus BlockVerifier.
Add unit tests for BlockVerifier state error handling.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
Move BlockVerifier and its tests from src/verify.rs to
src/verify/block.rs.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
Cleanup the error handling in the block verifier tests.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
Move BlockVerifier and its tests from src/verify.rs to
src/verify/block.rs.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
Cleanup the error handling in the block verifier tests.

Part of ZcashFoundation#428.
teor2345 added a commit to teor2345/zebra that referenced this issue Jun 24, 2020
@hdevalence hdevalence changed the title Block validation service. Tracking: block validation Aug 11, 2020
@hdevalence hdevalence added C-tracking-issue Category: This is a tracking issue for other tasks and removed C-research Category: Engineering notes in support of design choices Poll::Ready labels Aug 11, 2020
@mpguerra mpguerra added the Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped label Nov 17, 2020
@mpguerra mpguerra removed this from the Block Validation milestone Jan 5, 2021
@mpguerra mpguerra removed the E-med label Mar 23, 2021
@mpguerra
Copy link
Contributor

moved remaining issues out to other epics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-consensus Area: Consensus rule updates C-tracking-issue Category: This is a tracking issue for other tasks Epic Zenhub Label. Denotes a theme of work under which related issues will be grouped
Projects
None yet
Development

No branches or pull requests

5 participants