Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Orchard proof batch verification #4672

Closed
2 tasks
conradoplg opened this issue Jun 22, 2022 · 3 comments
Closed
2 tasks

Add support for Orchard proof batch verification #4672

conradoplg opened this issue Jun 22, 2022 · 3 comments
Labels
C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness S-blocked Status: Blocked on other tasks

Comments

@conradoplg
Copy link
Collaborator

conradoplg commented Jun 22, 2022

Motivation

The halo2_proofs crate does not yet support batch verification (I think it does but we don't use it yet, but in any case its performance was improved recently). When it does, we should use it, since there are some blocks with many Orchard actions that are taking seconds to validate.

Designs

Related Work

@conradoplg conradoplg added S-blocked Status: Blocked on other tasks C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage P-Medium ⚡ I-slow Problems with performance or responsiveness labels Jun 22, 2022
@dconnolly dconnolly self-assigned this Jun 27, 2022
@dconnolly
Copy link
Contributor

Looking at the changes in https://github.com/zcash/orchard/pull/338/files, we will probably pull in halo2_proofs::plonk::BatchVerifier and slot that into our tower::Service

@conradoplg conradoplg added P-High 🔥 and removed S-blocked Status: Blocked on other tasks P-Medium ⚡ labels Jun 30, 2022
@dconnolly dconnolly removed the S-needs-triage Status: A bug report needs triage label Jul 5, 2022
@ftm1000 ftm1000 added the S-blocked Status: Blocked on other tasks label Jul 11, 2022
@teor2345
Copy link
Contributor

Note commitment tree updates are slower than proofs, and single-threaded, so they are a higher priority than orchard batching.

@teor2345
Copy link
Contributor

Performance improvements are a low priority right now.

@mpguerra mpguerra moved this to 🆕 New in Zebra Sep 22, 2022
@mpguerra mpguerra added this to Zebra Sep 22, 2022
@teor2345 teor2345 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 1, 2022
Repository owner moved this from 🆕 New to ✅ Done in Zebra Dec 1, 2022
@mpguerra mpguerra moved this from ✅ Done to 🛑 Won't Fix in Zebra Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: This is an improvement I-slow Problems with performance or responsiveness S-blocked Status: Blocked on other tasks
Projects
Archived in project
Development

No branches or pull requests

4 participants