-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sync): change default sync config to improve reliability #4670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
Category: This is a bug
P-Critical 🚑
I-hang
A Zebra component stops responding to requests
I-integration-fail
Continuous integration fails, including build and test failures
A-network
Area: Network protocol updates or fixes
labels
Jun 22, 2022
3 tasks
10 tasks
Codecov Report
@@ Coverage Diff @@
## main #4670 +/- ##
==========================================
- Coverage 78.86% 78.81% -0.05%
==========================================
Files 304 304
Lines 37504 37509 +5
==========================================
- Hits 29578 29564 -14
- Misses 7926 7945 +19 |
2 tasks
conradoplg
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
teor2345
added a commit
that referenced
this pull request
Jun 23, 2022
This is a partial revert of PR #4670.
1 task
conradoplg
pushed a commit
that referenced
this pull request
Jun 23, 2022
This is a partial revert of PR #4670.
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2022
This is a partial revert of PR #4670.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-network
Area: Network protocol updates or fixes
C-bug
Category: This is a bug
I-hang
A Zebra component stops responding to requests
I-integration-fail
Continuous integration fails, including build and test failures
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra is a bit slow to verify orchard blocks with lots of transactions, which can cause a failure loop.
This PR should reduce the concurrency a bit, allowing it to sync more reliably.
Solution
Concurrency:
Priority:
Cancellation:
Review
This is pretty urgent, it seems to be blocking a lot of other fixes and tests.
Reviewer Checklist