Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): change default sync config to improve reliability #4670

Merged
merged 5 commits into from
Jun 22, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

Zebra is a bit slow to verify orchard blocks with lots of transactions, which can cause a failure loop.

This PR should reduce the concurrency a bit, allowing it to sync more reliably.

Solution

Concurrency:

  • Decrease the default lookahead limit from 2000 to 400
  • Increase the block verification timeout from 6 to 10 minutes
  • Decrease the default concurrent downloads config from 50 to 25

Priority:

  • Try to run the spawned download task before queueing the next download

Cancellation:

  • Allow verification to be cancelled if the verifier is busy

Review

This is pretty urgent, it seems to be blocking a lot of other fixes and tests.

Reviewer Checklist

  • Full sync works more reliably

@teor2345 teor2345 added C-bug Category: This is a bug P-Critical 🚑 I-hang A Zebra component stops responding to requests I-integration-fail Continuous integration fails, including build and test failures A-network Area: Network protocol updates or fixes labels Jun 22, 2022
@teor2345 teor2345 self-assigned this Jun 22, 2022
@teor2345 teor2345 requested review from a team as code owners June 22, 2022 03:43
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team June 22, 2022 03:43
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #4670 (1952f11) into main (82b8d7f) will decrease coverage by 0.04%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #4670      +/-   ##
==========================================
- Coverage   78.86%   78.81%   -0.05%     
==========================================
  Files         304      304              
  Lines       37504    37509       +5     
==========================================
- Hits        29578    29564      -14     
- Misses       7926     7945      +19     

Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

mergify bot added a commit that referenced this pull request Jun 22, 2022
@mergify mergify bot merged commit c75a68e into main Jun 22, 2022
@mergify mergify bot deleted the sync-reliability branch June 22, 2022 18:17
teor2345 added a commit that referenced this pull request Jun 23, 2022
This is a partial revert of PR #4670.
conradoplg pushed a commit that referenced this pull request Jun 23, 2022
This is a partial revert of PR #4670.
mergify bot pushed a commit that referenced this pull request Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug I-hang A Zebra component stops responding to requests I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants