-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sync): Slightly increase some syncer defaults #4679
Conversation
This is a partial revert of PR #4670.
I'm running a full sync here: We want it to get higher than 85% at 6 hours. |
Codecov Report
@@ Coverage Diff @@
## main #4679 +/- ##
==========================================
+ Coverage 78.81% 78.93% +0.11%
==========================================
Files 304 304
Lines 37509 37509
==========================================
+ Hits 29564 29606 +42
+ Misses 7945 7903 -42 |
It timed out at 96.781%, so it seems good? |
Yep that's much better, we'll fix the timeout with #4661 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working as expected (sync is faster in the tested workflow). As it's a very straightforward change I'll approve it so we can test PRs being dependent on this one.
Motivation
We changed the syncer defaults to make full verification more reliable, but that slowed down syncing by about 15%.
This is a partial revert of PR #4670.
Solution
This is a temporary fix until we get orchard batch verification.
Review
This PR needs a full sync test before it gets merged.
Reviewer Checklist