Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): Slightly increase some syncer defaults #4679

Merged
merged 1 commit into from
Jun 24, 2022
Merged

Conversation

teor2345
Copy link
Contributor

Motivation

We changed the syncer defaults to make full verification more reliable, but that slowed down syncing by about 15%.

This is a partial revert of PR #4670.

Solution

  • Increase the syncer defaults to about halfway between the previous and current defaults

This is a temporary fix until we get orchard batch verification.

Review

This PR needs a full sync test before it gets merged.

Reviewer Checklist

  • Full sync is greater than 85% at 6 hours

This is a partial revert of PR #4670.
@teor2345 teor2345 added C-bug Category: This is a bug P-High 🔥 I-slow Problems with performance or responsiveness A-network Area: Network protocol updates or fixes labels Jun 23, 2022
@teor2345 teor2345 self-assigned this Jun 23, 2022
@teor2345
Copy link
Contributor Author

I'm running a full sync here:
https://github.com/ZcashFoundation/zebra/actions/runs/2546930195

We want it to get higher than 85% at 6 hours.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #4679 (023479b) into main (c75a68e) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4679      +/-   ##
==========================================
+ Coverage   78.81%   78.93%   +0.11%     
==========================================
  Files         304      304              
  Lines       37509    37509              
==========================================
+ Hits        29564    29606      +42     
+ Misses       7945     7903      -42     

@conradoplg
Copy link
Collaborator

It timed out at 96.781%, so it seems good?

@teor2345 teor2345 marked this pull request as ready for review June 23, 2022 22:48
@teor2345 teor2345 requested review from a team as code owners June 23, 2022 22:48
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team June 23, 2022 22:48
@teor2345
Copy link
Contributor Author

It timed out at 96.781%, so it seems good?

Yep that's much better, we'll fix the timeout with #4661

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is working as expected (sync is faster in the tested workflow). As it's a very straightforward change I'll approve it so we can test PRs being dependent on this one.

mergify bot added a commit that referenced this pull request Jun 23, 2022
@mergify mergify bot merged commit 49cda21 into main Jun 24, 2022
@mergify mergify bot deleted the higher-sync-defaults branch June 24, 2022 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-bug Category: This is a bug I-slow Problems with performance or responsiveness
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants