Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make tests wait until lightwalletd full sync goes all the way to the tip #4894

Closed
Tracked by #3096
teor2345 opened this issue Aug 5, 2022 · 1 comment · Fixed by #5164
Closed
Tracked by #3096

Make tests wait until lightwalletd full sync goes all the way to the tip #4894

teor2345 opened this issue Aug 5, 2022 · 1 comment · Fixed by #5164
Assignees
Labels
A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug C-testing Category: These are tests lightwalletd any work associated with lightwalletd

Comments

@teor2345
Copy link
Contributor

teor2345 commented Aug 5, 2022

Motivation

lightwalletd doesn't reliably log when it reaches the chain tip.

In PR #4828, we added a workaround to the lightwalletd full sync test, which stops at a fixed height near the chain tip. But for tests like #4350, we need to wait until it has actually reached the tip.

Designs

Make the lightwalletd full sync, update sync, grpc, and send transaction tests wait until lightwalletd has reached the chain tip.

We could do this by checking that the Zebra JSON-RPC and lightwalletd gRPC heights match. (We can't do it using the logs, because lightwalletd doesn't reliably log block heights.)

The lightwalletd_integration_test() already does most of this work, we might want to call it from the grpc and send transaction tests.

@teor2345 teor2345 added C-bug Category: This is a bug S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels Aug 5, 2022
@teor2345 teor2345 changed the title Wait until lightwalletd full sync goes all the way to the tip Make tests wait until lightwalletd full sync goes all the way to the tip Aug 23, 2022
@teor2345 teor2345 self-assigned this Aug 25, 2022
@teor2345
Copy link
Contributor Author

teor2345 commented Sep 5, 2022

The lightwalletd_integration_test() already does most of this work, we might want to call it from the grpc and send transaction tests.

@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Sep 15, 2022
@mpguerra mpguerra moved this to 🆕 New in Zebra Sep 22, 2022
@mpguerra mpguerra added this to Zebra Sep 22, 2022
@mpguerra mpguerra moved this from 🆕 New to 🏗 In progress in Zebra Sep 22, 2022
@teor2345 teor2345 assigned teor2345 and upbqdn and unassigned arya2 and oxarbitrage Sep 26, 2022
@mergify mergify bot closed this as completed in #5164 Oct 6, 2022
Repository owner moved this from 🏗 In progress to ✅ Done in Zebra Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-bug Category: This is a bug C-testing Category: These are tests lightwalletd any work associated with lightwalletd
Projects
Archived in project
5 participants