Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GetMempoolTx and GetMempoolStream gRPC tests #4350

Closed
Tracked by #4278
, #3096
...
ftm1000 opened this issue May 6, 2022 · 2 comments · Fixed by #5016
Closed
Tracked by #4278
, #3096
...

Add GetMempoolTx and GetMempoolStream gRPC tests #4350

ftm1000 opened this issue May 6, 2022 · 2 comments · Fixed by #5016
Assignees
@teor2345 @oxarbitrage
Labels
lightwalletd any work associated with lightwalletd S-blocked Status: Blocked on other tasks

Comments

@ftm1000
Copy link

ftm1000 commented May 6, 2022 •
edited by teor2345
Loading

Motivation

In #4253 we added tests for grpc wallet methods, however we left a few TODOs in the main file (zebrad/tests/common/lightwalletd/wallet_grpc_test.rs) for missing tests.

Tasks

Add a test for:

  • GetMempoolTx
  • GetMempoolStream

The send transaction test populates the mempool, so we can add these extra gRPC calls to the end of that test.

Draft Implementation

PR #4537 has a draft implementation.
@ftm1000 ftm1000 mentioned this issue May 6, 2022
Closed
3 tasks
@ftm1000 ftm1000 added S-needs-triage Status: A bug report needs triage lightwalletd any work associated with lightwalletd labels May 6, 2022
@ftm1000
Copy link
Author

ftm1000 commented May 6, 2022

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @oxarbitrage @teor2345 @upbqdn

@ftm1000
Copy link
Author

ftm1000 commented May 6, 2022

Split from #4278

@conradoplg conradoplg changed the title GetMempoolTx Add GetMempoolTx gRPC test May 6, 2022
@ftm1000 ftm1000 added P-High 🔥 and removed S-needs-triage Status: A bug report needs triage labels May 6, 2022
@oxarbitrage oxarbitrage self-assigned this May 17, 2022
@oxarbitrage oxarbitrage mentioned this issue May 30, 2022
Closed
3 tasks
@dconnolly dconnolly added the S-blocked Status: Blocked on other tasks label Jun 27, 2022
@teor2345 teor2345 mentioned this issue Aug 5, 2022
Closed
@teor2345 teor2345 mentioned this issue Aug 23, 2022
Closed
76 tasks
@teor2345 teor2345 mentioned this issue Aug 31, 2022
Merged
3 tasks
@teor2345 teor2345 self-assigned this Aug 31, 2022
@teor2345 teor2345 changed the title Add GetMempoolTx gRPC test Add GetMempoolTx and GetMempoolStream gRPC tests Aug 31, 2022
@mergify mergify bot closed this as completed in #5016 Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

@oxarbitrage oxarbitrage

Labels
lightwalletd any work associated with lightwalletd S-blocked Status: Blocked on other tasks
Projects
None yet
Milestone
No milestone
4 participants
@dconnolly @teor2345 @oxarbitrage @ftm1000