Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing wallet grpc tests #4278

Closed
2 of 3 tasks
oxarbitrage opened this issue May 3, 2022 · 2 comments
Closed
2 of 3 tasks

Add missing wallet grpc tests #4278

oxarbitrage opened this issue May 3, 2022 · 2 comments
Labels
A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests lightwalletd any work associated with lightwalletd

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented May 3, 2022

In #4253 we added tests for grpc wallet methods, however we left a few TODOs in the main file (zebrad/tests/common/lightwalletd/wallet_grpc_test.rs)for missing tests.

This ticket is for add them:

The stream ones should be easy, the tree state should also be easy after #3990 is in place. Mempool ones are harder as we will have to add some transaction to the mempool from the test (idea: need to use code from zebrad/tests/common/lightwalletd/send_transaction_test.rs)

@teor2345 teor2345 added P-Medium ⚡ C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels May 3, 2022
@ftm1000
Copy link

ftm1000 commented May 5, 2022

@teor2345
Copy link
Contributor

There's just one sub-ticket left here, so I'm going to close this tracking issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests lightwalletd any work associated with lightwalletd
Projects
None yet
Development

No branches or pull requests

3 participants