-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(rpc): Add wallet grpc tests #4253
Conversation
FYI here is how i am running this test locally:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good so far, and makes sense to leave the simpler tests and add more complicated tests later.
I'm not sure about how we're handling the tests that require some state. I think some of them have #[ignore]
so that they are only run explicitly (even if this runs only with ZEBRA_TEST_LIGHTWALLETD
). I need to check the current state of the other tests, though.
I can resume taking a closer look at this PR tomorrow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a great test, I just have a few suggestions for making it more reliable.
@Mergifyio update |
✅ Branch has been successfully updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but we need the latest CI fixes to make the tests run reliably.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like all the tests passed!
Motivation
We want to test all the possible calls a wallet connected to a lightwalletd server can possible do.
Close #3655
Solution
This PR add very basic tests that could be extended for a series of rpc methods a wallet connected to lightwalletd can possible call.
There are a few tests that are depending on merging additional code to main.
Review
I am looking some feedback in regards to the tests. Should we make more complicated stuff now or try to merge this code and open additional smaller issues to complete what we want ?
Any ideas to implement in this PR ?
I think @teor2345 and/or @conradoplg are good candidates to take a look.
Reviewer Checklist