Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Populate transactions of BlockTemplate #5454

Closed
Tracked by #5235
, #5234
...
oxarbitrage opened this issue Oct 21, 2022 · 2 comments · Fixed by #5508
Closed
Tracked by #5235
, #5234
...

Populate transactions of BlockTemplate #5454

oxarbitrage opened this issue Oct 21, 2022 · 2 comments · Fixed by #5508
Assignees
@teor2345

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Oct 21, 2022 •
edited by teor2345
Loading

Motivation

The transactions field of the BlockTemplate response is an array of BlockTemplateTx structure with the transaction data and other fields.

Tasks

  • Create BlockTemplateTx
  • bring transactions from the mempool and populate the transactions.data fields. Tracking: Implement getblocktemplate RPC #5235 (comment)
    • the depends field is always an empty list, Zebra's mempool doesn't support dependent transactions
  • Populate the additional fields of BlockTemplateTx

Depends on #5451
This was referenced Oct 21, 2022
Closed
Closed
Merged
@teor2345 teor2345 mentioned this issue Oct 24, 2022
Closed
8 tasks
@mpguerra
Copy link
Contributor

Hey team! Please add your planning poker estimate with Zenhub @arya2 @conradoplg @dconnolly @oxarbitrage @teor2345 @upbqdn

@teor2345
Copy link
Contributor

I split ZIP-317 transaction selection out of this ticket into #5473.

It seems like separate work, and it depends on some details that the zcashd developers haven't decided yet.

@mpguerra mpguerra changed the title 5- Populate transactions of BlockTemplate Populate transactions of BlockTemplate Oct 26, 2022
@mpguerra mpguerra mentioned this issue Oct 26, 2022
Closed
34 tasks
@teor2345 teor2345 self-assigned this Oct 27, 2022
This was referenced Oct 28, 2022
Merged
Merged
Merged
@mergify mergify bot closed this as completed in #5508 Nov 3, 2022
@teor2345 teor2345 mentioned this issue Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

3. change(rpc): Add fee and sigops fields to getblocktemplate transactions ZcashFoundation/zebra
3 participants
@mpguerra @teor2345 @oxarbitrage