-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): introduce getblocktemplate rpc call with stub fields #5462
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5462 +/- ##
==========================================
+ Coverage 79.10% 79.21% +0.11%
==========================================
Files 308 309 +1
Lines 39324 39351 +27
==========================================
+ Hits 31107 31172 +65
+ Misses 8217 8179 -38 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think longpollid
is out of scope for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we want to use underscores to match the rest of the RPC implementations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
I think this is a high priority, because it renames the module that all the other RPCs are in. If we don't get it merged soon, it will cause code conflicts.
Motivation
This is pretty much what i have in mind for #5451
It introduces the rpc call and all the fields using mostly strings as placeholders. All data will be filled in the other tickets, this is kind of the skeleton.
This is a draft, feel free to suggest changes.
Solution
Introduce
getblocktemplate
rpc methjod, return emptyGetblockTemplate
struct on call.Review
Reviewer Checklist
Follow Up Work
Blocktemplate
responses with fixed values data #5452BlockTemplate
fields using a new state request #5455BlockTemplate
#5453BlockTemplate
#5454