Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually test that Zcash mining pools can use Zebra to mine blocks on testnet #5934

Closed
Tracked by #5937 ...
teor2345 opened this issue Jan 9, 2023 · 13 comments
Closed
Tracked by #5937 ...
Assignees
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-consensus Area: Consensus rule updates A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests

Comments

@teor2345
Copy link
Contributor

teor2345 commented Jan 9, 2023

Motivation

We should run Zebra with mining pool software before asking other mining pools to test it.

Complex Code or Requirements

A bunch of us have done some work on this, it's tricky to get the right dependencies to deploy most mining pools.

Related Work

Here is our previous discussion about mining pool testing.

@teor2345 teor2345 added A-consensus Area: Consensus rule updates S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces A-compatibility Area: Compatibility with other nodes or wallets, or standard rules labels Jan 9, 2023
@teor2345
Copy link
Contributor Author

I think we should put a time limit of one day on this ticket. If we can't get it working quickly, we can contact an actual mining pool later to help with testing, when we've done more RPCs.

@mpguerra
Copy link
Contributor

I think we should put a time limit of one day on this ticket. If we can't get it working quickly, we can contact an actual mining pool later to help with testing, when we've done more RPCs.

Agreed

@ZcashFoundation/zebra-team can whoever has done some research and/or testing add their notes to this issue.

Scheduling for Sprint 2 as I'd like to get all of the testing resolved in the next sprint

@mpguerra
Copy link
Contributor

@mpguerra
Copy link
Contributor

moving to Sprint 3 for now

@mpguerra mpguerra moved this to 🛑 Won't Fix in Zebra Jan 19, 2023
@mpguerra mpguerra added this to Zebra Jan 19, 2023
@mpguerra mpguerra moved this from 🛑 Won't Fix to 📋 Sprint Backlog in Zebra Jan 19, 2023
@teor2345 teor2345 self-assigned this Jan 25, 2023
@teor2345
Copy link
Contributor Author

I did some testing on this back in December, it was tricky because I couldn't get the node dependencies right. And some of the C libraries wouldn't compile on my machine.

But maybe using the node dependency lock files will help.

@upbqdn
Copy link
Member

upbqdn commented Jan 26, 2023

I made it work by modifying the source code and installation configs. I could pack it all into some container.

@teor2345
Copy link
Contributor Author

Even just a diff from the original source would help!

@mpguerra
Copy link
Contributor

mpguerra commented Feb 3, 2023

Let's document any successes we've had with this here and what we have done. This will help with #6028

@teor2345
Copy link
Contributor Author

teor2345 commented Feb 6, 2023

Let's document any successes we've had with this here and what we have done. This will help with #6028

These instructions are now at:
https://github.com/ZcashFoundation/s-nomp/blob/zebra-mining/zebra-instructions.md

Anyone can open PRs to improve them.

@arya2
Copy link
Contributor

arya2 commented Feb 7, 2023

🎉 The 6 Sols/s is a little sad but the instructions worked well for me. I had some trouble with installing dependencies for s-nomp, I think export CXXFLAGS="-std=gnu++17" is important there.

image

image

@teor2345
Copy link
Contributor Author

teor2345 commented Feb 7, 2023

The 6 Sols/s is a little sad but the instructions worked well for me.

This is normal for 1-3 cores, so it might help to document it in the instructions.

I had some trouble with installing dependencies for s-nomp, I think export CXXFLAGS="-std=gnu++17" is important there.

Can you please open an PR to update the instructions? I think those flags are marked as optional, but if they are required we should remove the "optional".

https://github.com/ZcashFoundation/s-nomp/blob/zebra-mining/zebra-instructions.md

@oxarbitrage
Copy link
Contributor

I was able to mine as well:

mined

@mpguerra
Copy link
Contributor

mpguerra commented Feb 8, 2023

I think everyone has managed to mine a block now. 👏

@mpguerra mpguerra closed this as completed Feb 8, 2023
@github-project-automation github-project-automation bot moved this from 📋 Sprint Backlog to ✅ Done in Zebra Feb 8, 2023
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-compatibility Area: Compatibility with other nodes or wallets, or standard rules A-consensus Area: Consensus rule updates A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests
Projects
Status: Done
Development

No branches or pull requests

5 participants