Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a regtest() constructor method to Network #7839

Closed
Tracked by #7119
mpguerra opened this issue Oct 26, 2023 · 3 comments · Fixed by #8413
Closed
Tracked by #7119

Add a regtest() constructor method to Network #7839

mpguerra opened this issue Oct 26, 2023 · 3 comments · Fixed by #8413
Assignees
Labels
A-network Area: Network protocol updates or fixes C-feature Category: New features C-testing Category: These are tests

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Oct 26, 2023

Motivation

This has been requested, and could be useful for testing.

Possible Design

Add a method that returns a Network::Testnet with Regtest parameters.

@mpguerra mpguerra added this to Zebra Oct 26, 2023
@github-project-automation github-project-automation bot moved this to 🆕 New in Zebra Oct 26, 2023
@mpguerra mpguerra changed the title Add a Regtest variant to Network, update From<Network> for &'static str for db_path(), default port, and genesis hash Add a Regtest variant to Network Oct 26, 2023
@mpguerra mpguerra added A-network Area: Network protocol updates or fixes C-testing Category: These are tests C-feature Category: New features S-needs-triage Status: A bug report needs triage P-Medium ⚡ C-enhancement Category: This is an improvement NU-6 Network Upgrade: NU6 specific tasks labels Oct 26, 2023
@arya2 arya2 changed the title Add a Regtest variant to Network Add a Regtest constant of Network::Testnet Oct 26, 2023
@teor2345
Copy link
Contributor

teor2345 commented Oct 26, 2023

I don't think we should make this change add a Regtest variant to Network, I think we should add fields to the existing Testnet enum variant instead, like @arya2 and I talked about.

@teor2345 teor2345 removed the C-enhancement Category: This is an improvement label Oct 30, 2023
@mpguerra mpguerra added this to the NU6 milestone Jan 19, 2024
@arya2 arya2 added the S-blocked Status: Blocked on other tasks label Feb 19, 2024
@arya2
Copy link
Contributor

arya2 commented Feb 19, 2024

This is blocked on adding some of the hard-coded parameters that need to be changed for RegTest to the Network::Testnet variant in #7845

@mpguerra
Copy link
Contributor Author

Does the issue title accurately reflect what we are going to do here?

@arya2 arya2 changed the title Add a Regtest constant of Network::Testnet Add a regtest() constructor method to Network Feb 20, 2024
@mpguerra mpguerra moved this from New to Sprint Backlog in Zebra Mar 6, 2024
@mpguerra mpguerra modified the milestones: NU6, Regtest Mar 6, 2024
@arya2 arya2 self-assigned this Apr 18, 2024
@arya2 arya2 moved this from Sprint Backlog to In progress in Zebra Apr 18, 2024
@arya2 arya2 removed S-needs-triage Status: A bug report needs triage S-blocked Status: Blocked on other tasks labels Apr 18, 2024
@arya2 arya2 moved this from In progress to Review/QA in Zebra Apr 18, 2024
@mergify mergify bot closed this as completed in #8413 Apr 25, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Apr 25, 2024
@mpguerra mpguerra removed the NU-6 Network Upgrade: NU6 specific tasks label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-network Area: Network protocol updates or fixes C-feature Category: New features C-testing Category: These are tests
Projects
Archived in project
3 participants