Add tests for Chain implementation

[yaahc]

Motivation

Solution

Related Issues

• Tracking: State Update RFC Implementation #1049 - tracking issue that describes the proptest design for this PR

Related PRs

• Implement RFC5: State updates Chain type #1069 - the implementation this tests
• export proptest impls for use in downstream crates #1092 - exports zebra-chain Arbitrary impls and strategies required to implement the Chain proptests

[dconnolly]

i love tests

[teor2345]

Looks good!

Let's fix the slow tests issue before we merge, so we don't impact other developers.

Otherwise, this is all fantastic!

[teor2345]

@yaahc what do we need to do to get this merged?

[teor2345]

I merged #1090 into the state RFC, so we might have some conflicts here. Hopefully they will disappear in the rebase.

[yaahc]

@yaahc what do we need to do to get this merged?

I think its just a bit of cleanup, make sure the tests dont run to wrong, etc. But first I want to try to see if I can't figure out why the sync is hanging when I use the full impl in the follow up PR

[teor2345]

@yaahc what do we need to do to get this merged?

I think its just a bit of cleanup, make sure the tests dont run to wrong, etc.

It would be nice to fix rustfmt before we merge.

But first I want to try to see if I can't figure out why the sync is hanging when I use the full impl in the follow up PR

Can you point me to the specific PR?
And any relevant failure logs?
(Unfortunately, sync hangs can be hard to diagnose - we need better futures tooling to find livelocked and deadlocked futures.)

There are a lot of PRs open right now, so I want to make sure I have the right one.

[teor2345]

I think we're good here, as long as CI passes.