-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft RFC: Block subsidy #1129
Draft RFC: Block subsidy #1129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start for a design!
Thanks for the tables and the headings, they make things a lot easier to read.
There's just a few things we need to tweak before we start implementing.
Co-authored-by: teor <teor@riseup.net>
It is clear from the signature that the function will return `Error` on any failure(including input errors, for example a wrong height). Describing this will force us to write it for all functions that returns an error so better remove it.
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to make changes based on Daira's suggestions.
I addressed all comments from @daira . Very appreciated, feel free to revisit the changes and let me know if any of them still need improvements. |
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Since we're checkpointing on Canopy, we can ignore Founders Reward validation. So we need to decide if we want to:
|
…rafts/xxxx-block-subsidy.md
We've decided to merge this RFC as a draft for now, see #338 for more details. |
TODO
See #338
Transaction Fee Validation Rules
Coinbase Source Validation Rules
Summary
Zebra manages semantic verification in the
zebra-consensus
crate, this is done for all incoming blocks. Inside each block the coinbase transaction is special, it holds the subsidy rewards that are paid to different participants(miners, founders, stream receivers). This RFC describes how to implement the needed calculations and verification for block subsidy and miner fees.More information
Feature Name:
block_subsidy
Start Date: 2020-10-05
Design PR: ZcashFoundation/zebra#1129
Zebra Issue: None by now
Document
Rendered.
Zebra Team Approval
Everyone on the Zebra team should review design RFCs: