Use RedJubjub types in zebra-chain. #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
approved these changes
Dec 12, 2019
| /// | ||
| /// XXX refine to a specific type. | ||
| pub rk: [u8; 32], | ||
| pub rk: redjubjub::PublicKeyBytes<SpendAuth>, |
| /// XXX refine to a specific type: redjubjub signature? | ||
| /// XXX for now it's [u64; 8] instead of [u8; 64] to get trait impls | ||
| pub spend_auth_sig: [u64; 8], | ||
| pub spend_auth_sig: redjubjub::Signature<SpendAuth>, |
| // XXX refine this type to a RedJubjub signature. | ||
| // for now it's [u64; 8] rather than [u8; 64] to get trait impls | ||
| pub binding_sig: [u64; 8], | ||
| pub binding_sig: redjubjub::Signature<Binding>, |
skyl
added a commit
to skyl/zebra
that referenced
this pull request
Sep 25, 2024
Co-authored-by: Jonathan Bird <jonathanbird+github@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticks one box off of #123
Closes #125.