Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log when the syncer awaits peer readiness #1714

Merged
merged 2 commits into from
Feb 9, 2021
Merged

Log when the syncer awaits peer readiness #1714

merged 2 commits into from
Feb 9, 2021

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 9, 2021

Motivation

#1435 causes the peer set to stay in a pending state, which makes the ChainSync hang when it calls ready_and for network requests.

Solution

Log at info-level before calling ready_and on the peer set, for better diagnostics.

Closes #1633.

The underlying bug in #1633 should be fixed by PR #1709 and ticket #1435.

Review

This is a small routine logging change.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup labels Feb 9, 2021
@teor2345 teor2345 added this to the 2021 Sprint 3 milestone Feb 9, 2021
@teor2345 teor2345 requested a review from a team February 9, 2021 01:17
@teor2345 teor2345 self-assigned this Feb 9, 2021
@teor2345 teor2345 mentioned this pull request Feb 9, 2021
Closed
oxarbitrage
oxarbitrage approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok with this changes.

@teor2345 teor2345 merged commit dce1135 into main Feb 9, 2021
@teor2345 teor2345 deleted the sync-hang-log branch February 9, 2021 21:09
dconnolly pushed a commit that referenced this pull request Feb 11, 2021
@teor2345 @dconnolly
Log when the syncer awaits peer readiness (#1714)
fd0cf9e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
2021 Sprint 3
Development

Successfully merging this pull request may close these issues.

zebrad syncer hangs when there are no peers, despite network timeouts
2 participants
@teor2345 @oxarbitrage