Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the global span to spawned network init tasks #1761

Merged
merged 1 commit into from
Feb 19, 2021

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 17, 2021

Motivation

When I was trying to diagnose a hang bug on crawl_and_dial, it didn't have the global git commit span, so it was hard to work out if it was already fixed by #1709.

Here is what the logs look like before this change:

Feb 17 10:18:59.606  WARN crawl_and_dial: zebra_network::peer_set::set: network request with no peer connections. Hint: check your network connection

Solution

Add the global span to spawned network init tasks

Review

This review is a low priority.

Related Issues

Closes #1575

@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code P-Low labels Feb 17, 2021
@teor2345 teor2345 self-assigned this Feb 17, 2021
@teor2345
Copy link
Contributor Author

Testnet seems unstable right now, affecting CI. That will be fixed by #1222 in the next sprint.

@teor2345 teor2345 requested a review from a team February 19, 2021 10:25
@teor2345
Copy link
Contributor Author

It looks like we didn't get a fresh merge for CI after #1789, so the testnet sync failed again.

Merging anyway, because #1789 deletes that code, so it can't possibly fail on main.

@teor2345 teor2345 merged commit d4f2f27 into ZcashFoundation:main Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global span doesn't appear on some early spawned tasks
3 participants