Stop sending blocks and transactions on error #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaahc
approved these changes
Feb 25, 2021
dconnolly
approved these changes
Feb 25, 2021
This was referenced Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Zebra continues sending blocks and transactions to peers after there is an error on the connection.
This causes panics like #1599.
Solution
Return after the first error when sending blocks or transactions.
Review
@yaahc is doing the refactor of this code.
This fix is urgent, because it stops Zebra panicking when peer connections have errors.
Related Issues
#1610 - initial refactor attempt
#1817 - current refactor attempt
Follow Up Work
Finish the refactor that prevents future bugs like this #1817