CandidateSet: Document Listener Port Connections #1852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inbound connections on the Zcash protocol listener port perform a handshake. If the handshake is successful, it adds the peer to the AddressBook.
dconnolly
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The current
CandidateSetstate diagram doesn't document how peer addresses from inbound connections get into theAddressBook.Solution
Inbound connections on the Zcash protocol listener port perform a handshake. If the handshake is successful, it adds the peer to the
AddressBook.Change the
CandidateSetdescription and diagram to document this missing state transition.Review
@dconnolly and I discussed this change as part of the zebra-network security fixes. It is a medium priority.
Related Issues
Limit reconnection rate to each individual peer address #1848
Zebra should eventually stop trying to contact peers that always fail #1849
Limit the number of active peers in zebra-network #1850
Follow Up Work
Actually fix the security issues