Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Disable unreliable sync_large_checkpoints_testnet" #1877

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 9, 2021

Now that we've done #1222, we can re-enable these tests.

Reverts #1789

Closes #1791.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement P-Medium labels Mar 9, 2021
@teor2345 teor2345 self-assigned this Mar 9, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Mar 9, 2021

This PR failed in an unrelated test, #1878 should fix it.

I'm re-running the tests to make sure that it's a rare failure.

@teor2345
Copy link
Contributor Author

Second test passed, let's run again just to be sure.

@teor2345
Copy link
Contributor Author

Yep, the latest test run also looks fine, I'm also going to run it locally just to be sure.

@dconnolly dconnolly added this to the 2021 Sprint 5 milestone Mar 10, 2021
@dconnolly dconnolly merged commit ac4611f into main Mar 10, 2021
@dconnolly dconnolly deleted the revert-1789-large-sync-testnet-disable branch March 10, 2021 07:14
@teor2345
Copy link
Contributor Author

I ran the zebrad acceptance tests --including-ignored with #1877 and #1878 in a loop on my local machine, until one of the tests failed.

For the first few test runs, I got:

3 successes before the first failure due to a bad set of initial peers from the DNS seeders (only 2 good peers)
28 successes before the first failure due to a bad set of initial peers from the DNS seeders (only 1 good peer)
4 successes before the first failure due to a bad set of initial peers from the DNS seeders (only 3 good peers)
25 successes before the first failure due to a bad set of initial peers from the DNS seeders (only 1 good peer)

That's about a 7% failure rate - I'm not sure if that's acceptable. But my local machine has a much higher latency and lower network speed than our CI, so CI could fail a lot less often.

If the rate ever gets too high, we can double the number of zcashd or Zebra peers that we have deployed on testnet. (Our network security fixes and DNS seeder redeployment should also increase the number of good peers in the set of seeder peers, see #1753 and the recent network security tickets.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Re-enable sync_large_checkpoints_testnet test
2 participants