Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document peer set deadlock resistance #1972

Merged
merged 2 commits into from
Apr 2, 2021
Merged

Document peer set deadlock resistance #1972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06fbe3d
Document peer set deadlock resistance
teor2345 Apr 1, 2021
bd501b7
Add a line break
dconnolly Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions zebra-network/src/peer_set/set.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -462,8 +462,14 @@ where
self.update_metrics();

if self.preselected_p2c_index.is_none() {
// CORRECTNESS
//
// If the channel is full, drop the demand signal rather than waiting.
// If we waited here, the crawler could deadlock sending a request to
// fetch more peers, because it also empties the channel.
trace!("no ready services, sending demand signal");
let _ = self.demand_signal.try_send(());

// CORRECTNESS
dconnolly marked this conversation as resolved.
Show resolved Hide resolved
//
// The current task must be scheduled for wakeup every time we
Expand Down