Rename the NU5 block commitment variant based on what it commits to #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change helps avoid confusion with block commitment variants in future network upgrades, which may add more hashes to the commitment list.
dconnolly
reviewed
Apr 7, 2021
dconnolly
approved these changes
Apr 7, 2021
Yeah I wasn't sure what to call it, but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The NU5 block commitment variant has a generic name. But we want to name it based on the data it commits to.
This change helps avoid confusion with block commitment variants in future network upgrades, which may add more hashes to the commitment list.
Solution
Review
Anyone can review, this small change is not urgent.
Related Issues
Cleanup after #1957
Follow Up Work
Actually implement the hash