Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use meaningful names for select! variables #2007

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Use meaningful names for select! variables #2007

merged 1 commit into from
Apr 14, 2021

Conversation

teor2345
Copy link
Contributor

Motivation

select! blocks are easier to read if the variables have meaningful names.

Review

@dconnolly asked for this change in #1950. It is a routine cleanup.

@teor2345 teor2345 added A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-Medium labels Apr 14, 2021
@teor2345 teor2345 added this to the 2021 Sprint 7 milestone Apr 14, 2021
@teor2345 teor2345 requested a review from dconnolly April 14, 2021 00:54
@teor2345 teor2345 self-assigned this Apr 14, 2021
@dconnolly dconnolly merged commit a417c7c into ZcashFoundation:main Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup
Projects
None yet
Milestone
2021 Sprint 7
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @dconnolly