Make debugging easier on proptests with large vectors #2232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also add it to some more proptest vectors.
This makes debugging easier
teor2345
added
A-rust
dconnolly
reviewed
Jun 1, 2021
jvff
reviewed
Jun 1, 2021
1 task
jvff
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
It's hard to diagnose a proptest failure when you get hundreds of pages of log output.
Solution
SummaryDebugtypeThe code in this pull request has:
Review
This code can be reviewed by anyone, but we'll all want it next time a block or chain test fails :-)
Related Issues
Some of this code was accidentally deleted in PR #2012.
I really needed it when the chain proptests in #2185 were failing. (But they're fixed now.)