Update transaction::check::coinbase_tx_no_joinsplit_or_spend to validate V5 coinbase transactions with Orchard shielded data
#2236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvff
changed the title
transaction::check::coinbase_tx_nojoinsplit_or_spend to validate V5 coinbase transactions with Orchard shielded data
jvff
changed the title
transaction::check::coinbase_tx_nojoinsplit_or_spend to validate V5 coinbase transactions with Orchard shielded datatransaction::check::coinbase_tx_no_joinsplit_or_spend to validate V5 coinbase transactions with Orchard shielded data
teor2345
reviewed
Jun 2, 2021
teor2345
suggested changes
Jun 2, 2021
teor2345
previously approved these changes
Jun 3, 2021
teor2345
reviewed
Jun 3, 2021
Allows accessing the Orchard shielded data if it is present in the transaction, regardless of the transaction version.
Allows making the method more concise.
Used when the validation rule is not met.
The flag must not be set for the coinbase transaction.
jvff
force-pushed
the
update-coinbase-tx-no-joinsplit-or-spend
branch
from
452ea30 to
ffe09fa
Compare
Use the fact that `Option<T>` implements `Iterator<T>` to simplify the code and remove the need for boxing the iterators. Co-authored-by: teor <teor@riseup.net>
jvff
force-pushed
the
update-coinbase-tx-no-joinsplit-or-spend
branch
from
ffe09fa to
bc29da7
Compare
teor2345
approved these changes
Jun 3, 2021
5 tasks
14 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
NU5 has the consensus rule that V5 coinbase transactions must not have the enableSpendsOrchard flag set.
Solution
Implement the consensus rule in the
coinbase_tx_no_joinsplit_or_spendfunction, as described in #1980.The code in this pull request has:
Review
@teor2345 outlined the solution, and @oxarbitrage is working on similar Orchard issues.
Related Issues
Part of #1980.
Follow Up Work