Update state RFC for incremental trees, value pools, and RocksDB #2456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-docs
teor2345
commented
Jul 8, 2021
conradoplg
reviewed
Jul 9, 2021
conradoplg
requested changes
Jul 9, 2021
teor2345
commented
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to update the state RFC to document the RocksDB data structures we use for:
I also added some basic documentation about how RocksDB handles updates and deletes.
Designs
Based on the designs in the PRs and tickets linked above.
Solution
This PR does not close any tickets, it is part of the tickets and PRs linked above.
Review
@oxarbitrage and @conradoplg are working on the incremental history and value pools designs.
Reviewer Checklist