Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return valid Utxos from check::transparent_spend #2561

Merged
merged 2 commits into from
Aug 3, 2021
Merged

Return valid Utxos from check::transparent_spend #2561

merged 2 commits into from
Aug 3, 2021

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Aug 3, 2021 •
edited by mpguerra
Loading

Motivation

In tickets #2381 and #1895, we need to lookup the Utxos spent by each block, to get the values of the transparent inputs.

Solution

  • Return the valid looked up Utxos from check::transparent_spend

This PR does not close any tickets.

Review

@oxarbitrage needs this PR to finish the value balance work.

Reviewer Checklist

  • Code does what future PRs need
  • Function documentation is up to date

We'll test this PR when we use the returned Utxos.

This change is Reviewable

@teor2345
Return valid Utxos from check::transparent_spend
80dfd58 
Later PRs will use these UTXOs to check other transparent consensus rules.
@teor2345 teor2345 added NU-1 Sapling Network Upgrade: Sapling specific tasks NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-5 Network Upgrade: NU5 specific tasks labels Aug 3, 2021
@teor2345 teor2345 added this to the 2021 Sprint 15 milestone Aug 3, 2021
@teor2345 teor2345 self-assigned this Aug 3, 2021
oxarbitrage
oxarbitrage approved these changes Aug 3, 2021
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, i am going to merge this and then submit another one where we check the remaining value balance(among with some implementation of some of changes we did to the design) and see if the tests pass.

@oxarbitrage oxarbitrage enabled auto-merge (squash) August 3, 2021 20:23
@oxarbitrage oxarbitrage merged commit 86bbafd into main Aug 3, 2021
@oxarbitrage oxarbitrage deleted the return-looked-up-uxtos branch August 3, 2021 20:53
@oxarbitrage oxarbitrage mentioned this pull request Aug 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU Sprout Network Upgrade: Sprout specific tasks (before Overwinter) NU-1 Sapling Network Upgrade: Sapling specific tasks NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
2021 Sprint 15
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @oxarbitrage