Stop using prop_filter_map to produce valid sapling shielded data #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves proptest results in CI and locally. Proptests should be faster, because they are not discarding 1/16 results. Failures should be minimised more often, improving failure logs, and generating proptest seeds locally and in CI.
teor2345
added
NU-1 Sapling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To test Zebra using generated data, we need proptests to:
This is related to tickets #2381 and #1895, and a lot of other current validation tickets.
But it doesn't close any of those tickets.
Solution
Previously, on 1/16 runs Zebra would generate invalid data, then skip it using
prop_filter_map. This was a particular issue during test case minimisation, because minimisation sets vector sizes to zero. (Zero spends and zero outputs is invalid.)Review
Anyone can review this PR. It's not particularly urgent.
Reviewer Checklist
This change is