Add a CoinbaseData field, replacing Vec<u8>. #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dconnolly
approved these changes
Feb 19, 2020
| pub struct CoinbaseData( | ||
| /// Invariant: this vec, together with the coinbase height, must be less than | ||
| /// 100 bytes. We enforce this by only constructing CoinbaseData fields by | ||
| /// parsing blocks with 100-byte data fields. When we implement block |
|
|
|
oops, that's on me for just running cargo check |
The CoinbaseData field can only be constructed by the transaction parser, so we can ensure that a coinbase input is always serializable, as CoinbaseData instances can't be constructed outside of the parser that maintains the data size invariant.
hdevalence
force-pushed
the
coinbase-data-type
branch
from
8e10540
to
65b0dbe
Compare
|
fixed & amended |
dconnolly
approved these changes
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CoinbaseData field can only be constructed by the transaction parser, so we
can ensure that a coinbase input is always serializable, as CoinbaseData
instances can't be constructed outside of the parser that maintains the data
size invariant.