Stop converting Message::Inv(TxId+) into Request::TransactionsById

[teor2345]

Motivation

Message::Inv(TxId+) is a transaction advertisement, so it should be converted into Request::AdvertiseTransactionIds.

This is a copy-paste mistake from the original zebra-network implementation.

This bug is unexpected work in sprint 17.

Specifications

The “inv” message (inventory message) transmits one or more inventories of objects known to the transmitting peer. It can be sent unsolicited to announce new transactions or blocks...

https://developer.bitcoin.org/reference/p2p_networking.html#inv

Designs

zebra/zebra-network/src/protocol/internal/request.rs

Lines 137 to 159 in bc4194f

	/// Advertise a set of unmined transactions to all peers.
	///
	/// This is intended to be used in Zebra with a single transaction at a time
	/// (set of size 1), but multiple transactions are permitted because this is
	/// how we interpret advertisements from zcashd, which sometimes advertises
	/// multiple transactions at once.
	///
	/// This is implemented by sending an `inv` message containing the
	/// unmined transaction ID, allowing the remote peer to choose whether to download
	/// it. Remote peers who choose to download the transaction will generate a
	/// [`Request::TransactionsById`] against the "inbound" service passed to
	/// [`zebra_network::init`].
	///
	/// v4 transactions use a legacy transaction ID, and
	/// v5 transactions use a witnessed transaction ID.
	///
	/// The peer set routes this request specially, sending it to *every*
	/// available peer.
	///
	/// # Returns
	///
	/// Returns [`Response::Nil`](super::Response::Nil).
	AdvertiseTransactionIds(HashSet<UnminedTxId>),

Solution

• use AdvertiseTransactionIds for inbound Inv requests from peers

Review

@jvff can review this PR.
@oxarbitrage might also be interested, because this fix is needed for #1077

Reviewer Checklist

• Code implements Specs and Designs

Follow Up Work

We'll use and test this message in #1077

[dconnolly]

👍