Implement best tip block hashes for ChainTip receivers #2677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
2 tasks
teor2345
force-pushed
the
block-hash-chain-updates
branch
from
8783ec4 to
2483813
Compare
teor2345
force-pushed
the
block-hash-chain-updates
branch
from
2483813 to
4661cd5
Compare
|
@jvff this is ready for review now, I'll do the optimisations in a separate PR. |
This significantly simplifies the internal implementation of ChainTipSender. Also make the methods and types a bit more generic.
Also fix a bug where queued non-finalized blocks would clear the chain tip.
The finalized and non-finalized tips never update to `None` once they have added at least one block.
teor2345
force-pushed
the
block-hash-chain-updates
branch
from
c545eed to
5eb464c
Compare
3 tasks
jvff
previously approved these changes
Aug 27, 2021
Also return the highest committed queued block.
dconnolly
reviewed
Aug 27, 2021
dconnolly
reviewed
Aug 27, 2021
dconnolly
reviewed
Aug 27, 2021
dconnolly
approved these changes
Aug 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In ticket #2639, we want to get block hashes, transaction information, and rollback information out of the state.
The
ChainTipstruct already gets block heights out of the state.In this PR, I've added block hashes to the
ChainTipinformation.Solution
Optimisation:
This PR does not close any tickets.
Review
@jvff can review this PR.
This PR is based on PR #2676.
Reviewer Checklist
Follow Up Work
Do the rest of ticket #2639: transaction IDs, resets, initialization and missed update handling.