Add transaction IDs to the chain tip channel #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
teor2345
changed the title
Base automatically changed from
optimise-chain-updates
to
block-hash-chain-updates
August 27, 2021 18:45
jvff
approved these changes
Aug 27, 2021
jvff
previously approved these changes
Aug 27, 2021
This avoids serializing and deserializing blocks from the finalized state.
Co-authored-by: Janito Vaqueiro Ferreira Filho <janito.vff@gmail.com>
teor2345
force-pushed
the
chain-tip-transaction-ids
branch
from
e43a1c1 to
e1d2153
Compare
|
Admin-merged after applying review suggestions and rebasing on the latest main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to provide the mined transaction IDs for the chain tip as part of Get recent committed & rolled back blocks from the state service #2639
We want to optimise chain tip updates, by re-using precalculated finalized and non-finalized block hashes, heights, and transaction IDs
Solution
Add chain tip mined transaction IDs
Optimisation:
This is part of #2639, but doesn't close that ticket.
Review
@jvff has been reviewing this series of chain tip updates PRs
This PR is based on PR #2683, it might need a manual rebase before it merges.
Reviewer Checklist
I modified the existing tests to cover the optimisations and the transaction hashes.
Follow Up Work
Handle chain tip resets (#2639)