Make chain tip updates and access more efficient #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transaction `Hash`es are 32 bytes, and the minimun transparent transaction size is 54 bytes. So a full 2MB block can create 1.1MB of transaction hashes. We use an `Arc` to avoid repeatedly cloning that much data.
This drops the block as soon as it isn't needed any more. Previously, it would stick around until every `ChainTipReceiver` dropped their `ChainTipBlock`, even if they didn't use the `Block` at all.
teor2345
added
A-rust
This was referenced Aug 30, 2021
oxarbitrage
approved these changes
Aug 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
These changes make
ChainTipReceivera bit more efficient, since we're going to be using it in a few different places.They are part of ticket #2639, but they don't close that ticket.
Solution
ArcBlockfromChainTipBlockReview
@oxarbitrage can review this PR.
It's not urgent, but it would be good to get it done early this week.
Reviewer Checklist
Follow Up Work
Do the reset parts of #2639