Pass the mempool config to the mempool #2861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - expand config docs - clean up mempool imports
This simplifies all the code that calls the mempool. Also: - update the mempool enabled state before returning the new mempool - add some test module doc comments
Also: - update the setup function to handle the latest mempool changes
teor2345
added
A-rust
teor2345
commented
Oct 12, 2021
teor2345
commented
Oct 12, 2021
3 tasks
dconnolly
reviewed
Oct 12, 2021
Comment on lines
+135
to
+145
| _config: &Config, | ||
| outbound: Outbound, | ||
| state: State, | ||
| tx_verifier: TxVerifier, | ||
| sync_status: SyncStatus, | ||
| latest_chain_tip: zs::LatestChainTip, | ||
| chain_tip_change: ChainTipChange, | ||
| transaction_sender: watch::Sender<HashSet<UnminedTxId>>, | ||
| ) -> Self { | ||
| Mempool { | ||
| ) -> (Self, watch::Receiver<HashSet<UnminedTxId>>) { | ||
| let (transaction_sender, transaction_receiver) = | ||
| tokio::sync::watch::channel(HashSet::new()); | ||
|
|
dconnolly
reviewed
Oct 12, 2021
Comment on lines
+157
to
+159
| // Make sure `is_enabled` is accurate. | ||
| // Otherwise, it is only updated in `poll_ready`, right before each service call. | ||
| service.update_state(); |
dconnolly
reviewed
Oct 12, 2021
Comment on lines
+10
to
+27
| /// The mempool transaction cost limit. | ||
| /// | ||
| /// This limits the total serialized byte size of all transactions in the mempool. | ||
| /// | ||
| /// This corresponds to `mempooltxcostlimit` from [ZIP-401](https://zips.z.cash/zip-0401#specification). | ||
| pub tx_cost_limit: u32, | ||
|
|
||
| /// The mempool transaction eviction age limit. | ||
| /// | ||
| /// This limits the maximum amount of time evicted transaction IDs stay in the mempool rejection list. | ||
| /// Transactions are randomly evicted from the mempool when the mempool reaches [`tx_cost_limit`]. | ||
| /// | ||
| /// (Transactions can also be rejected by the mempool for other reasons. | ||
| /// Different rejection reasons can have different age limits.) | ||
| /// | ||
| /// This corresponds to `mempoolevictionmemoryminutes` from | ||
| /// [ZIP-401](https://zips.z.cash/zip-0401#specification). | ||
| pub eviction_memory_time: Duration, |
dconnolly
reviewed
Oct 12, 2021
Comment on lines
+30
to
+36
| /// Consensus rules: | ||
| /// | ||
| /// > There MUST be a configuration option mempooltxcostlimit, | ||
| /// > which SHOULD default to 80000000. | ||
| /// > | ||
| /// > There MUST be a configuration option mempoolevictionmemoryminutes, | ||
| /// > which SHOULD default to 60 [minutes]. |
dconnolly
reviewed
Oct 12, 2021
Comment on lines
+650
to
+658
| async fn setup( | ||
| network: Network, | ||
| ) -> ( | ||
| Mempool, | ||
| MockPeerSet, | ||
| StateService, | ||
| MockTxVerifier, | ||
| RecentSyncLengths, | ||
| ) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To implement ZIP-401, we need to pass the mempool config to the mempool.
This is a high priority, because ZIP-401 is on the critical path.
This PR is unexpected work - it wasn't done as part of creating the mempool config.
Solution
Functionality:
Refactors:
Review
@dconnolly might want to review this PR, because the config is needed for ticket #2780.
Reviewer Checklist
Follow Up Work