Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update some zebra-network dependencies #2935

Closed

Conversation

jvff
Copy link
Contributor

@jvff jvff commented Oct 21, 2021

Motivation

This is part of the update to use Tokio version 1 (#2200), and must be merged together with the other PRs.

The newer version of Tokio uses some updated dependencies, and Zebra has to update those dependencies to be compatible.

More specifically, the bytes and the tokio-util crates have to be updated.

Solution

The bytes crate was updated to 1.1 and the tokio-util crate was updated to 0.6.

Review

Anyone from the team can review this, but it shouldn't be merged yet.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

Use versions compatible with Tokio version 1.
@jvff jvff requested a review from a team October 21, 2021 22:01
@jvff jvff self-assigned this Oct 21, 2021
@mpguerra mpguerra mentioned this pull request Oct 29, 2021
10 tasks
@mpguerra mpguerra requested review from conradoplg and removed request for a team October 29, 2021 14:02
conradoplg
conradoplg previously approved these changes Oct 29, 2021
Copy link
Collaborator

@conradoplg conradoplg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I also confirmed that other usages of tokio-util (e.g. by hyper) will be updated to that same version when those crates are updated too.

@jvff jvff mentioned this pull request Nov 1, 2021
3 tasks
Use a stricter dependency specification.
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made suggestions for all the missing patch versions on the rollup PR.

@jvff jvff requested review from teor2345 and conradoplg November 2, 2021 01:17
@jvff
Copy link
Contributor Author

jvff commented Nov 2, 2021

Merged through #2994.

@jvff jvff closed this Nov 2, 2021
@jvff jvff deleted the update-some-zebra-network-dependencies branch November 24, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants