Panic if Zebra exceeds its connection limit #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
P-High
C-security
3 tasks
teor2345
force-pushed
the
panic-peer-limit
branch
from
1a19c8d to
d03a1f5
Compare
teor2345
force-pushed
the
limit-outbound-peers
branch
from
4b453b6 to
3839027
Compare
teor2345
force-pushed
the
panic-peer-limit
branch
from
d03a1f5 to
95a5284
Compare
teor2345
force-pushed
the
limit-outbound-peers
branch
2 times, most recently
from
8ec9c93 to
6188022
Compare
teor2345
force-pushed
the
panic-peer-limit
branch
from
95a5284 to
9720df7
Compare
teor2345
force-pushed
the
limit-outbound-peers
branch
from
6188022 to
e51afcb
Compare
teor2345
force-pushed
the
panic-peer-limit
branch
from
9720df7 to
6c6a94c
Compare
teor2345
force-pushed
the
limit-outbound-peers
branch
from
e51afcb to
4315699
Compare
teor2345
force-pushed
the
panic-peer-limit
branch
2 times, most recently
from
856cfbe to
deeb503
Compare
teor2345
changed the base branch from
limit-outbound-peers
to
limit-inbound-peers
jvff
approved these changes
Oct 27, 2021
teor2345
force-pushed
the
limit-inbound-peers
branch
from
ea49fcf to
b50e322
Compare
teor2345
force-pushed
the
panic-peer-limit
branch
from
deeb503 to
630f935
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This is a runtime check for PR #2944 and PR #2961.
It's based on those PRs.
Solution
Panic if the
PeerSethas more peers than the totalinbound + outboundconnection limit.Review
@jvff is reviewing PRs #2944 and #2961.
Reviewer Checklist