Re-order Zebra startup, so slow services are launched last #3091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
teor2345
commented
Nov 23, 2021
teor2345
force-pushed
the
startup-slow-services-last
branch
from
26db90a
to
d750d12
Compare
Pass all dependent services to the inbound service via a channel. This means we can initialize more services after the inbound service.
This makes the Groth16 download task start as late as possible.
teor2345
force-pushed
the
startup-slow-services-last
branch
from
d750d12
to
701b437
Compare
teor2345
commented
Nov 23, 2021
teor2345
commented
Nov 23, 2021
This was referenced Nov 23, 2021
teor2345
force-pushed
the
startup-slow-services-last
branch
from
2c28de9
to
701b437
Compare
3 tasks
|
This PR might even cut a few minutes off our CI times, because expected failures happen faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some of Zebra's network conflict tests are failing. This is probably happening due to PR Download Zcash Sapling parameters and load them from cached files #3057, which added a download task to verifier setup.
Zebra can be slow to shut down. The new download task in PR Download Zcash Sapling parameters and load them from cached files #3057 could make this problem worse.
This is unexpected work in Sprint 23, but we could call it part of ticket #3037 if we want.
Solution
Review
This PR fixes CI failures, so it's pretty important.
It blocks PR #3085, which makes the download task much bigger.
@conradoplg was interested in fixing this issue, but anyone whose PRs are failing should review it.
Reviewer Checklist
Follow Up Work