-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft design for lightwalletd database support #3137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-docs
Area: Documentation
C-design
Category: Software design work
P-Medium
labels
Dec 3, 2021
teor2345
force-pushed
the
lightwallet-db-changes
branch
from
December 3, 2021 06:10
8ac42ff
to
d8851b2
Compare
2 tasks
33 tasks
teor2345
force-pushed
the
update-state-rfc
branch
from
December 6, 2021 02:21
2020817
to
74f50eb
Compare
teor2345
force-pushed
the
lightwallet-db-changes
branch
3 times, most recently
from
December 6, 2021 03:56
64d13b6
to
04b525d
Compare
teor2345
commented
Dec 6, 2021
teor2345
commented
Dec 6, 2021
teor2345
force-pushed
the
update-state-rfc
branch
from
December 9, 2021 23:25
cec2a20
to
a69802d
Compare
teor2345
force-pushed
the
lightwallet-db-changes
branch
from
December 9, 2021 23:26
04b525d
to
67c2f83
Compare
teor2345
force-pushed
the
lightwallet-db-changes
branch
from
December 13, 2021 22:53
67c2f83
to
7aedc1e
Compare
dconnolly
approved these changes
Dec 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## main #3137 +/- ##
==========================================
+ Coverage 77.03% 77.77% +0.73%
==========================================
Files 265 264 -1
Lines 31267 31013 -254
==========================================
+ Hits 24088 24121 +33
+ Misses 7179 6892 -287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-docs
Area: Documentation
C-design
Category: Software design work
lightwalletd
any work associated with lightwalletd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To support
lightwalletd
, Zebra needs to:This design change helps us estimate those changes, and open tickets.
This is unexpected work in Sprint 24.
Specifications
List of lightwalletd RPC methods:
Impacted RPCs:
Solution
Review
Anyone can review this database design change.
Reviewer Checklist
Follow Up Work