Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sprout keys and addresses #317

Merged
merged 39 commits into from
Mar 28, 2020
Merged

Sprout keys and addresses #317

merged 39 commits into from
Mar 28, 2020

Commits on Mar 24, 2020

  1. Move TransparentAddress stuff to its own module

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    57e7c29 View commit details
    Browse the repository at this point in the history

  2. Use secp256k1 serde flag to make keys serializable

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    1201d96 View commit details
    Browse the repository at this point in the history

  3. Finish migration of TransparentAddress out of addresses.rs

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    b4e17f5 View commit details
    Browse the repository at this point in the history

  4. Impl zcash_deserialize for secp256k1::PublicKey

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    6545b56 View commit details
    Browse the repository at this point in the history

  5. Add module-level doc comment for keys/transparent.rs

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    320bada View commit details
    Browse the repository at this point in the history

  6. Module-level doc comments

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    ab4d38c View commit details
    Browse the repository at this point in the history

  7. Add x25519-dalek as dependency

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    ebcec8d View commit details
    Browse the repository at this point in the history

  8. Add the beginnings of Sprout and Sapling key types

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    4bf815d View commit details
    Browse the repository at this point in the history

  9. Filling out Sprout and Sapling Shielded Addresses

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    9797687 View commit details
    Browse the repository at this point in the history

  10. Move magic bytes to nested private modules for t-addrs

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    01acf6b View commit details
    Browse the repository at this point in the history

  11. Update SproutShieldedAddress types 

    Use magics module.
Stub out key types, including a TransmissionKey alias for x25519_dalek::PublicKey
    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    7d3383d View commit details
    Browse the repository at this point in the history

  12. Docs

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    548cac0 View commit details
    Browse the repository at this point in the history

  13. Make ReceivingKey a type alias for x25519_dalek::StaticSecret 

    Plus some doc comments
    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    e60bd73 View commit details
    Browse the repository at this point in the history

  14. Pull in fork of sha2 that exposes compress256 round function

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    ca3a92f View commit details
    Browse the repository at this point in the history

  15. Derive Sprout ReceivingKey's from SpendingKey's via SHA256Compress 

    Test is incomplete, also the type aliases block us from impl'ing Debug or Display.
    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    966e47a View commit details
    Browse the repository at this point in the history

  16. Derive PayingKey's from SpendingKey's 

    And test that we can still derive TransmissionKey's from PayingKey's,
as they are aliases for x25519_dalek PublicKey/StaticSecret types that already
impl From<_> for each other.
    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    6e3a158 View commit details
    Browse the repository at this point in the history

  17. Add a TODO comment

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    f1108b1 View commit details
    Browse the repository at this point in the history

  18. Clippy tidy

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    bb0cc36 View commit details
    Browse the repository at this point in the history

  19. Use compress feature flag with hashes crate and re-exported compress256

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    4778dfe View commit details
    Browse the repository at this point in the history

  20. Update Cargo.lock

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    e125bf6 View commit details
    Browse the repository at this point in the history

  21. Use updated RustCrypto/hashes source of sha2

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    968dad1 View commit details
    Browse the repository at this point in the history

  22. Impl PartialEq and Eq for SproutShieldedAddress

    @dconnolly
    dconnolly committed Mar 24, 2020
    Configuration menu
    Copy the full SHA
    c0179e7 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2020

  1. Impl Arbitrary for SproutShieldedAddress and add roundtrip test

    @dconnolly
    dconnolly committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    25301ed View commit details
    Browse the repository at this point in the history

  2. Update zebra-chain/src/addresses/sprout.rs doc comment 

    Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
    @dconnolly @daira
    dconnolly and daira authored Mar 25, 2020
    Configuration menu
    Copy the full SHA
    9254628 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2020

  1. Impl Debug and Display for SproutShieldedAddress

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    5346493 View commit details
    Browse the repository at this point in the history

  2. Impl Debug for PayingKey

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    b8d21a7 View commit details
    Browse the repository at this point in the history

  3. Explicitly use sha2::compress256

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f59621e View commit details
    Browse the repository at this point in the history

  4. Better doc comment for IncomingViewingKey

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    f5852bd View commit details
    Browse the repository at this point in the history

  5. Tidy

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    691b3d2 View commit details
    Browse the repository at this point in the history

  6. Fix typos and doc comments

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    4857680 View commit details
    Browse the repository at this point in the history

  7. Use a match on network inside SproutShieldedAddress::zcash_serialize()

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    5a4a492 View commit details
    Browse the repository at this point in the history

  8. Make a note to update to the crates.io version of sha2 when available

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    c0dbc8b View commit details
    Browse the repository at this point in the history

  9. Impl FromStr, tidy Debug and Display impls for TransparentAddress

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    86b693c View commit details
    Browse the repository at this point in the history

  10. Impl FromStr, tidy Debug for SproutShieldedAddress

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    9694a2d View commit details
    Browse the repository at this point in the history

  11. Add an explicit test for Display trait on SproutShieldedAddress

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    71c8d3a View commit details
    Browse the repository at this point in the history

  12. Add a new() and impl From<[u8; 32]> for SpendingKey 

    Currently fills/receives 32 random bytes and forces the top 4 bits to
zero, ala clamping. If there is a nicer way to csprng'ly fill 252 bits
without clamping, that would be nicer, less bias.
    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    3e099e2 View commit details
    Browse the repository at this point in the history

  13. s/weird/invalid/

    @dconnolly
    dconnolly committed Mar 27, 2020
    Configuration menu
    Copy the full SHA
    4702e4a View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2020

  1. Tidy *serialize for TransparentAddress with match on network

    @dconnolly
    dconnolly committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    70cd550 View commit details
    Browse the repository at this point in the history

  2. Clear up doc comments on SpendingKey

    @dconnolly
    dconnolly committed Mar 28, 2020
    Configuration menu
    Copy the full SHA
    8c30b14 View commit details
    Browse the repository at this point in the history