-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop ignoring some peers when updating the address book #3292
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3292 +/- ##
==========================================
+ Coverage 77.10% 77.21% +0.11%
==========================================
Files 265 265
Lines 31460 31462 +2
==========================================
+ Hits 24256 24293 +37
+ Misses 7204 7169 -35 |
I've tested this PR locally, and the crawler and address book metrics look a lot better. The number of peer addresses rises rapidly, and gets full after a few hours. And Zebra doesn't hang any more, even after a few days. |
e997b3f
to
28c8a58
Compare
Marking as a high priority, because this bug sometimes makes CI fail. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Motivation
Zebra was ignoring some peers when updating the address book.
This could be the cause of issues like #3042.
Solution
Review
This PR is ready for review.
I think @dconnolly can review this PR.
Reviewer Checklist
I've tested this PR locally, and the crawler and address book metrics look a lot better. The number of peer addresses rises rapidly, and gets full after a few hours. And Zebra doesn't hang any more, even after a few days.