Document the consensus rules for Section 3.6 #3338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3338 +/- ##
=======================================
Coverage 78.46% 78.46%
=======================================
Files 267 267
Lines 31523 31530 +7
=======================================
+ Hits 24734 24740 +6
- Misses 6789 6790 +1 |
|
Since #3283 was merged, this PR is ready for review. |
conradoplg
requested changes
Jan 20, 2022
|
Oops, I didn't notice Clippy is unhappy until now. I'll fix it. |
|
The Zcash parameter download timed out. @Mergifyio refresh |
✅ Pull request refreshed |
|
Oops @Mergifyio update |
✅ Branch has been successfully updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Each consensus rule from Zcash Protocol Specification should be documented in Zebra for the upcoming audit.
Solution
This PR documents the consensus rules stated in Section 3.6 of the specification.
Review
Anyone can review.
Reviewer Checklist
Closes #3211, however, a part of one of the consensus rules is documented by #3283, so the issue should be closed only after #3283 is merged. For this reason, I'll keep this PR as a draft until #3283 is merged.