Use 2022-01-14 nightly to workaround coverage issue #3366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
Can make an issue to go back to nightly when this is fixed? Or maybe beta, if beta supports the Coverage requirements |
Yep! Done in #3367 |
Codecov Report
@@ Coverage Diff @@
## main #3366 +/- ##
==========================================
+ Coverage 77.83% 77.88% +0.04%
==========================================
Files 266 266
Lines 31449 31449
==========================================
+ Hits 24478 24493 +15
+ Misses 6971 6956 -15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustcbrokecargo-llvm-covwhich we use for coverage, which is making our CI fail: taiki-e/cargo-llvm-cov#128The workaround is to pin to a older version of the nightly rust.
Motivation
Specifications
Designs
Solution
Review
Reviewer Checklist
Follow Up Work